Fix for broken JDBC's getColumn() (take 2)

From: Jeroen van Vianen <jeroen(dot)van(dot)vianen(at)satama(dot)com>
To: pgsql-jdbc(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Fix for broken JDBC's getColumn() (take 2)
Date: 2001-09-10 18:00:39
Message-ID: 5.1.0.14.2.20010910194701.00acbab0@ams010.satama.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc pgsql-patches

Hi,

Per the recent discussion there's been some code changes in JDBC's
DatabaseMetaData.getColumn(). I proposed a patch that would change the
number of queries to find out all columns in a table from 2 * N + 1 to 1 (N
being the number of columns reported) by using some outer joins. I also
fixed the fact that getColumns() only returned columns that had a default
defined. OTOH, I did not use to change the code required for obtaining a
column's remarks (by using col_description() for 7.2 and requested by Tom
Lane).

Finally, I have found a way to get all the column details in a single query
*and* use col_description() for 7.2 servers. A patch is attached. It
overrules René Pijlman's fix for this that was committed just today, but
still used N + 1 queries (sorry René ;-) )

I also fixed the return values for TABLE_CAT and TABLE_SCHEM from "" to
null, to be more standard compliant (and requested in René's mail found at
http://fts.postgresql.org/db/mw/msg.html?mid=1034253).

As always, the JDBC1 version has not been tested as I have no JDK 1.1
available.

Please review,

Jeroen

Attachment Content-Type Size
DatabaseMetaData.diff.gz application/octet-stream 3.1 KB

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Culley Harrelson 2001-09-11 03:12:48 Fwd: Re: unicode in 7.1
Previous Message Bruce Momjian 2001-09-10 15:08:01 Re: Fix DatabaseMetaDataTest in JDBC test suite

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2001-09-11 00:13:23 Re: Support building in a different directory on Solaris
Previous Message Peter Eisentraut 2001-09-10 17:58:55 Re: Configuring fdatasync for Solaris2