Re: [PATCHES] Fix for broken JDBC's getColumn() (take 2)

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Jeroen van Vianen <jeroen(dot)van(dot)vianen(at)satama(dot)com>
Cc: pgsql-jdbc(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] Fix for broken JDBC's getColumn() (take 2)
Date: 2001-09-29 03:08:12
Views: Raw Message | Whole Thread | Download mbox
Lists: pgsql-jdbc pgsql-patches

Patch applied. Thanks.

> Hi,
> Per the recent discussion there's been some code changes in JDBC's
> DatabaseMetaData.getColumn(). I proposed a patch that would change the
> number of queries to find out all columns in a table from 2 * N + 1 to 1 (N
> being the number of columns reported) by using some outer joins. I also
> fixed the fact that getColumns() only returned columns that had a default
> defined. OTOH, I did not use to change the code required for obtaining a
> column's remarks (by using col_description() for 7.2 and requested by Tom
> Lane).
> Finally, I have found a way to get all the column details in a single query
> *and* use col_description() for 7.2 servers. A patch is attached. It
> overrules Ren? Pijlman's fix for this that was committed just today, but
> still used N + 1 queries (sorry Ren? ;-) )
> I also fixed the return values for TABLE_CAT and TABLE_SCHEM from "" to
> null, to be more standard compliant (and requested in Ren?'s mail found at
> As always, the JDBC1 version has not been tested as I have no JDK 1.1
> available.
> Please review,
> Jeroen

[ Attachment, skipping... ]

> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

Bruce Momjian |
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-09-29 03:09:31 Re: Patch to put double quotes around all env variable tests
Previous Message Bruce Momjian 2001-09-28 19:56:07 Re: Trailing semicolons in psql patch

Browse pgsql-jdbc by date

  From Date Subject
Next Message Bruce Momjian 2001-09-29 03:11:06 Re: [PATCHES] fix for JDBC test suite
Previous Message Tony Grant 2001-09-28 15:30:59 update