Re: Fix DatabaseMetaDataTest in JDBC test suite

Patch applied. Thanks.

> Attached is a patch that fixes DatabaseMetaDataTest in the JDBC
> driver's test suite. With previous patches applied, this reduces
> the number of failures of the test suite from 6 to 4. The patch
> fixes the test case itself, rather than the driver.
>
> Details:
>
> 1) The driver correctly provided DatabaseMetaData about the sort
> order of NULLs. This was confirmed by Peter Eisentraut on
> pgsql-hackers. I fixed the test to accept/require the current
> behaviour, and made it dependent on the backend version. See
> nullsAreSortedAtStart(), nullsAreSortedAtEnd(),
> nullsAreSortedHigh() and nullsAreSortedLow().
>
> 2) DatabaseMetaData.supportsOrderByUnrelated() correctly
> returned true (an ORDER BY clause can contain columns that are
> not in the SELECT clause), but the test case required false.
> Fixed that.
>
> 3) Replaced deprecated assert() of junit.framework.TestCase by
> assertEquals(), assertTrue() and assertNotNull(). This is
> because assert will be a new keyword in Java 1.4.
>
> 4) Replaced assert(message,false) by the more elegant
> fail(message).
>
> Regards,
> Ren? Pijlman <rene(at)lab(dot)applinet(dot)nl>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026