| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dominique Devienne <ddevienne(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Identifying function-lookup failures due to argument name mismatches |
| Date: | 2025-08-27 15:42:27 |
| Message-ID: | 4ec76052-8614-4733-b417-5ce476fb0e15@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 24.08.25 20:47, Tom Lane wrote:
> Here is a v4 with some additional bike-shedding on the error texts.
> In particular, I decided that it was worth expending an additional
> flag bit so that we could reliably distinguish "There is no function
> of that name" from "A function of that name exists, but it is not in
> the search_path". (Since FuncnameGetCandidates is already searching
> the entire set of functions matching the given name, it doesn't take
> any extra work to know that there's a match outside the search path.)
> I rephrased a couple of the other messages too, but without any
> substantive logic change.
I only gave it a quick review right now. I have also been wanting to
make the function lookup error messages more specific, so I like this
direction very much. The wording of the messages looks good and more
useful than before.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-08-27 15:42:50 | Re: Identifying function-lookup failures due to argument name mismatches |
| Previous Message | Xuneng Zhou | 2025-08-27 15:31:03 | Re: Improve read_local_xlog_page_guts by replacing polling with latch-based waiting |