Re: Identifying function-lookup failures due to argument name mismatches

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dominique Devienne <ddevienne(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Identifying function-lookup failures due to argument name mismatches
Date: 2025-08-24 18:47:12
Message-ID: 466727.1756061232@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here is a v4 with some additional bike-shedding on the error texts.
In particular, I decided that it was worth expending an additional
flag bit so that we could reliably distinguish "There is no function
of that name" from "A function of that name exists, but it is not in
the search_path". (Since FuncnameGetCandidates is already searching
the entire set of functions matching the given name, it doesn't take
any extra work to know that there's a match outside the search path.)
I rephrased a couple of the other messages too, but without any
substantive logic change.

regards, tom lane

Attachment Content-Type Size
v4-0001-Provide-more-specific-error-hints-for-function-lo.patch text/x-diff 39.7 KB
v4-0002-Change-the-wording-of-our-traditional-function-no.patch text/x-diff 29.4 KB
v4-0003-Improve-the-messages-for-operator-not-found-too.patch text/x-diff 23.7 KB
v4-0004-Mop-up-a-few-other-error-message-style-violations.patch text/x-diff 7.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-08-24 19:18:33 Re: Improve hash join's handling of tuples with null join keys
Previous Message Konstantin Knizhnik 2025-08-24 18:11:36 Re: Non-reproducible AIO failure