Re: PG Docs - CREATE SUBSCRIPTION option list order

From: "Euler Taveira" <euler(at)eulerto(dot)com>
To: "Peter Smith" <smithpb2250(at)gmail(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: PG Docs - CREATE SUBSCRIPTION option list order
Date: 2021-04-19 01:01:36
Message-ID: 4e7f13ab-98f9-4d96-8284-8cb9c17cfc3b@www.fastmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Apr 18, 2021, at 8:59 PM, Peter Smith wrote:
> The CREATE SUBSCRIPTION documentation [1] includes a list of "WITH"
> options, which are currently in some kind of quasi alphabetical /
> random order which I found unnecessarily confusing.
>
> I can't think of any good reason for the current ordering, so PSA my
> patch which has identical content but just re-orders that option list
> to be alphabetical.
AFAICS there is not reason to use a random order here. I think this parameter
list is in frequency of use. Your patch looks good to me.

--
Euler Taveira
EDB https://www.enterprisedb.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-04-19 01:24:01 Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows
Previous Message Peter Smith 2021-04-18 23:59:44 PG Docs - CREATE SUBSCRIPTION option list order