| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Set pg_class.relhassubclass for partitioned indexes |
| Date: | 2018-10-22 03:09:18 |
| Message-ID: | 4e562336-f632-2418-7d3d-ab0848df7aba@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2018/10/22 11:59, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> Set pg_class.relhassubclass for partitioned indexes
>
> Seems like this commit should have touched the catalogs.sgml description
> for that column, as well as the pg_class.h comment for it. Neither of
> those are worded in a way that suggests it could be set for non-table
> relations.
Oops, sorry.
Attached fixes catalog.sgml to say table or index instead of just table.
As for pg_class.h, changing just the following line might seem odd, as
along with the surrounding lines, maybe this really says, "relation has..."
bool relhassubclass; /* has (or has had) derived classes */
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| relhassubclass-doc.patch | text/plain | 595 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-10-22 03:12:12 | Re: pgsql: Set pg_class.relhassubclass for partitioned indexes |
| Previous Message | Michael Paquier | 2018-10-22 03:03:26 | Re: pgsql: Avoid duplicate XIDs at recovery when building initial snapshot |