|From:||Michael Paquier <michael(at)paquier(dot)xyz>|
|To:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|Subject:||Re: pgsql: Set pg_class.relhassubclass for partitioned indexes|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Sun, Oct 21, 2018 at 10:59:27PM -0400, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> Set pg_class.relhassubclass for partitioned indexes
> Seems like this commit should have touched the catalogs.sgml description
> for that column, as well as the pg_class.h comment for it. Neither of
> those are worded in a way that suggests it could be set for non-table
The pg_class.h comment looked fine for me first. How would you reword
relispartition tells "True if table is a partition", which is not
actually true as it can apply to indexes. So this should be changed in
v11 as well, no?
For relhassubclass, perhaps we could do a bit more than just referring
to children... What about the following:
"True if relation has (or once had) any inheritance children or
Here is the current formulation:
"True if table has (or once had) any inheritance children"
And this should be changed in v10~ additionally?
|Next Message||Tom Lane||2018-10-22 03:20:04||Re: pgsql: Set pg_class.relhassubclass for partitioned indexes|
|Previous Message||Amit Langote||2018-10-22 03:09:18||Re: pgsql: Set pg_class.relhassubclass for partitioned indexes|