From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, pgsql-docs(at)lists(dot)postgresql(dot)org |
Subject: | Re: Fix incorrect UUID index entry in function documentation |
Date: | 2025-06-24 05:37:07 |
Message-ID: | 4cf5c255-6801-4ca0-ae40-f1a418cb34c3@oss.nttdata.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs |
On 2025/06/24 0:46, Fujii Masao wrote:
>
>
> On 2025/06/23 23:52, Daniel Gustafsson wrote:
>>> On 23 Jun 2025, at 16:40, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>>
>>> So barring any objections, I will commit the patch.
>>
>> +1, LGTM.
>
> Thanks for the review!
>
>> There is one more occurrence though, the relnotes seem to need the
>> same treatment as they talk about UUID functions and not the UUID datatype:
>>
>> diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sgml
>> index 662c7d8890f..fba01d3ca44 100644
>> --- a/doc/src/sgml/release-18.sgml
>> +++ b/doc/src/sgml/release-18.sgml
>> @@ -2498,7 +2498,7 @@ Author: Masahiko Sawada <msawada(at)postgresql(dot)org>
>>
>> <listitem>
>> <para>
>> - Add <link linkend="datatype-uuid"><type>UUID</type></link>
>> + Add <link linkend="functions-uuid"><type>UUID</type></link>
>> version 7 generation function <link
>> linkend="func_uuid_gen_table"><function>uuidv7()</function></link>
>> (Andrey Borodin)
>
> That "UUID" here seems to refer to the general concept, so I don't think
> it needs to link specifically to the UUID functions page. Since the UUID
> data type page already provides a basic explanation, it makes sense for
> the link to point there. Also, since "uuidv7()" and "uuidv4()" there
> already link to the UUID functions page, that seems sufficient to me.
> Thought?
I've committed the proposed patch first. If we later agree to change
this part as well, we can commit that separately.
Regards,
--
Fujii Masao
NTT DATA Japan Corporation
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2025-06-24 07:19:53 | Re: "NewbieDoc Docbook Guide" link broken |
Previous Message | Michael Paquier | 2025-06-24 05:04:39 | Re: "NewbieDoc Docbook Guide" link broken |