Re: Fix incorrect UUID index entry in function documentation

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: Fix incorrect UUID index entry in function documentation
Date: 2025-06-23 15:46:17
Message-ID: 2b4a16fc-cec0-4e15-b8b1-c1a22401005b@oss.nttdata.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On 2025/06/23 23:52, Daniel Gustafsson wrote:
>> On 23 Jun 2025, at 16:40, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
>> So barring any objections, I will commit the patch.
>
> +1, LGTM.

Thanks for the review!

> There is one more occurrence though, the relnotes seem to need the
> same treatment as they talk about UUID functions and not the UUID datatype:
>
> diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sgml
> index 662c7d8890f..fba01d3ca44 100644
> --- a/doc/src/sgml/release-18.sgml
> +++ b/doc/src/sgml/release-18.sgml
> @@ -2498,7 +2498,7 @@ Author: Masahiko Sawada <msawada(at)postgresql(dot)org>
>
> <listitem>
> <para>
> - Add <link linkend="datatype-uuid"><type>UUID</type></link>
> + Add <link linkend="functions-uuid"><type>UUID</type></link>
> version 7 generation function <link
> linkend="func_uuid_gen_table"><function>uuidv7()</function></link>
> (Andrey Borodin)

That "UUID" here seems to refer to the general concept, so I don't think
it needs to link specifically to the UUID functions page. Since the UUID
data type page already provides a basic explanation, it makes sense for
the link to point there. Also, since "uuidv7()" and "uuidv4()" there
already link to the UUID functions page, that seems sufficient to me.
Thought?

Regards,

--
Fujii Masao
NTT DATA Japan Corporation

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message jian he 2025-06-24 04:17:46 "NewbieDoc Docbook Guide" link broken
Previous Message Daniel Gustafsson 2025-06-23 14:52:01 Re: Fix incorrect UUID index entry in function documentation