Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

From: David Steele <david(at)pgmasters(dot)net>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Chapman Flack <chap(at)anastigmatix(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file
Date: 2022-04-04 17:11:33
Message-ID: 4c4ae416-be44-754e-7ee0-7083c11e7cfb@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/4/22 11:42 AM, Nathan Bossart wrote:
> I noticed a couple of other things that can be removed. Since we no longer
> wait on exclusive backup mode during smart shutdown, we can change
> connsAllowed (in postmaster.c) to a boolean and remove CAC_SUPERUSER. We
> can also remove a couple of related notes in the documentation. I've done
> all this in the attached patch.

These changes look good to me. IMV it is a real bonus how much the state
machine has been simplified.

I've also run this patch through the pgbackrest regression tests without
any problems.

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-04-04 17:41:17 Re: New Object Access Type hooks
Previous Message Tom Lane 2022-04-04 17:03:10 Re: New Object Access Type hooks