| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | bharath(dot)rupireddyforpostgres(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Remove useless arguments in ReadCheckpointRecord(). |
| Date: | 2022-07-25 02:30:30 |
| Message-ID: | 4c27fe77-c1c9-b1aa-d6cf-b6e840a9f6ce@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022/07/22 17:31, Kyotaro Horiguchi wrote:
> I believed that it is recommended to move to the style not having the
> outmost parens. That style has been introduced by e3a87b4991.
I read the commit log, but I'm not sure yet if it's really recommended to remove extra parens even from the existing calls to errmsg(). Removing extra parens can interfere with back-patching of the changes around those errmsg(), can't it?
Anyway, at first I pushed the 0001 patch that removes useless arguments in ReadCheckpointRecord().
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-25 02:40:16 | Re: Remove useless arguments in ReadCheckpointRecord(). |
| Previous Message | Masahiko Sawada | 2022-07-25 01:45:46 | Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns |