| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Logical replication support for initial data copy |
| Date: | 2017-03-23 15:59:34 |
| Message-ID: | 4b7aa38b-3849-0b62-8266-c4fbaa6c691e@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 3/23/17 10:25, Petr Jelinek wrote:
> On 23/03/17 15:17, Stephen Frost wrote:
>> Petr,
>>
>> * Petr Jelinek (petr(dot)jelinek(at)2ndquadrant(dot)com) wrote:
>>> On 23/03/17 14:47, Petr Jelinek wrote:
>>>> I am looking into buildfarm failures.
>>>>
>>>> Looks like the clang issue (mylodon, longfin) is because we are missing
>>>> extern in include/replication/worker_internal.h for ApplyCacheContext.
>>>>
>>>> Still analyzing the rest.
>>>
>>> Ah missing fields in copy/equal function for AlterSubscriptionStmt.
>>>
>>> Attached patch adds the above mentioned extern and fixes the copy and
>>> equal functions.
>>
>> Pretty sure I saw a complaint about a trailing comma in a struct or enum
>> too..
>>
>
> Ah, missed that in the wall of text, thanks, fixed that too.
Also fixed.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2017-03-23 16:39:21 | pgsql: Reduce page locking in GIN vacuum |
| Previous Message | Peter Eisentraut | 2017-03-23 15:59:07 | pgsql: Remove trailing comma from enum definition |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Charles Cui | 2017-03-23 16:13:35 | Fwd: GSOC 2017 project ideas |
| Previous Message | Charles Cui | 2017-03-23 15:58:45 | GSOC 2017 project ideas |