| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Mark Dilger <hornschnorter(at)gmail(dot)com> |
| Subject: | Re: Escape output of pg_amcheck test |
| Date: | 2024-01-08 15:06:01 |
| Message-ID: | 4b3042f2-a8fa-4a88-8a06-2d0a6ffa99c8@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08.01.24 15:04, Aleksander Alekseev wrote:
>> [...] so I quickly wrote some (wrong) instrumentation to try to test your patch.
>
> Yep, it confused me too at first.
>
> Since the encoding happens right before exit() call, maybe it's worth
> changing $b in-place in order to make the code slightly more readable
> for most of us :)
My patch originally had the old-style
my $b_escaped = $b;
$b_escaped =~ s/.../;
... sprintf(..., $b_escaped);
but then I learned about the newish /r modifier and thought it was
cooler. :)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2024-01-08 15:42:34 | Re: SLRU optimization - configurable buffer pool and partitioning the SLRU lock |
| Previous Message | Adam S | 2024-01-08 14:54:51 | INSERT performance: less CPU when no indexes or triggers |