Re: Patch: add timing of buffer I/O requests

From: Greg Smith <greg(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jim Nasby <jim(at)nasby(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ants Aasma <ants(at)cybertec(dot)at>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patch: add timing of buffer I/O requests
Date: 2012-04-14 07:27:52
Message-ID: 4F8926F8.1010903@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 04/13/2012 06:22 PM, Tom Lane wrote:
> But (a) I *don't* want to seriously break things, and don't see a need
> to; (b) interval is expensive and has got its own problems, notably an
> internal limitation to usec resolution that we would not be able to get
> rid of easily.

A straight float seems pretty future proof compared to a usec resolution
interval. Jim was commenting in the same direction I already did, that
ns resolution is not impossible to see coming.

I also expect to compute plenty of derived statistics from these
numbers. Interval math is good enough that I'm sure such things could
be done, but it seems odd to start with those units. I appreciate that
the interval type has a nice purist feel to it. My pragmatic side says
we're going to pay overhead to create in that type, only to find people
end up converting it right back to other types for easier math tricks.

--
Greg Smith 2ndQuadrant US greg(at)2ndQuadrant(dot)com Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2012-04-14 07:27:58 Re: BUG #6572: The example of SPI_execute is bogus
Previous Message Alex 2012-04-14 07:02:21 Re: Last gasp