RE: ON CONFLICT DO NOTHING on pg_dump

From: "Ideriha, Takeshi" <ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Surafel Temesgen <surafel3000(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Subject: RE: ON CONFLICT DO NOTHING on pg_dump
Date: 2018-07-13 00:33:31
Message-ID: 4E72940DA2BF16479384A86D54D0988A6F14E20F@G01JPEXMBKW04
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, thanks for the revision.

>
>+ Add ON CONFLICT DO NOTHING clause in the INSERT commands.
>
>I think this would be better as: Add <literal>ON CONFLICT DO NOTHING</literal> to
><command>INSERT</command> commands.

Agreed.

>+ printf(_(" --on-conflict-do-nothing dump data as INSERT
>commands with ON CONFLICT DO NOTHING \n"));
>
>That's slightly misleading... let's just use the same wording again, eg "add ON
>CONFLICT DO NOTHING to INSERT commands".

Agreed. But you forgot fixing it at pg_dump.c.
So could you please fix this and commit it?

Regards,
Takeshi Ideriha

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-07-13 00:48:58 Re: pg_create_logical_replication_slot returns text instead of name
Previous Message Andrew Dunstan 2018-07-12 22:39:38 Re: Vacuum: allow usage of more than 1GB of work mem