| From: | "Ideriha, Takeshi" <ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com> | 
|---|---|
| To: | Michael Meskes <meskes(at)postgresql(dot)org> | 
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> | 
| Subject: | Re: [WIP] RE: DECLARE STATEMENT setting up a connection in ECPG | 
| Date: | 2017-01-06 09:10:29 | 
| Message-ID: | 4E72940DA2BF16479384A86D54D0988A56568D7A@G01JPEXMBKW04 | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
Hi
Thank you for looking over my patch.
> Thank you. Would it be possible for you to re-create the patch without the
> white-space changes?
I'm sorry for adding redundant white-spaces. 
Attached is a correct version.
> I noticed that the docs say the statement is a PostgreSQL addon.
> However, I think other databases do have the same statement, or don't they?
Yes, other databases such as Oracle and DB2 also have the same statement. 
I fixed docs and mentioned the above databases in the compatibility section.
But I'm not sure whether I should mention the other databases explicitly
because the other command docs don't mention Oracle or so explicitly in compatibility section
as long as I read.
Regards, 
Ideriha, Takeshi
> -----Original Message-----
> From: Michael Meskes [mailto:meskes(at)postgresql(dot)org]
> Sent: Sunday, January 1, 2017 7:18 PM
> To: Ideriha, Takeshi <ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com>
> Cc: pgsql-hackers(at)postgresql(dot)org
> Subject: Re: [WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in
> ECPG
> 
> Hi Ideriha-san,
> 
> > I created a patch.
> 
> Thank you. Would it be possible for you to re-create the patch without the
> white-space changes?
> 
> > I marked [WIP] to the title because some documentation is lacked and
> > format needs some fixing.
> 
> I noticed that the docs say the statement is a PostgreSQL addon.
> However, I think other databases do have the same statement, or don't they?
> 
> Michael
> --
> Michael Meskes
> Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes
> at (Debian|Postgresql) dot Org
> Jabber: michael at xmpp dot meskes dot org VfL Borussia! Força Barça! SF 49ers!
> Use Debian GNU/Linux, PostgreSQL
| Attachment | Content-Type | Size | 
|---|---|---|
| 001_declareStatement_v2.patch | application/octet-stream | 334.3 KB | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Beena Emerson | 2017-01-06 09:32:19 | Re: increasing the default WAL segment size | 
| Previous Message | Amit Langote | 2017-01-06 07:56:47 | Re: Declarative partitioning - another take |