| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Subject: | Re: Small patch for GiST: move childoffnum to child |
| Date: | 2011-07-13 17:20:31 |
| Message-ID: | 4E1DD3DF.4030009@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10.07.2011 21:43, Josh Berkus wrote:
> Teodor, Oleg, Heikki,
>
>> My concern is that I am unable to prove to myself simply by reading
>> the code that the 24 line chunk deleted from gistFindPath (near ***
>> 919,947 ****) are no longer needed. My familiarity with the gist code
>> is low enough that it is not surprising that I cannot prove this to
>> myself from first principles. I have no reason to believe it is not
>> correct, it is just that I can't convince myself that it is correct.
>
> Can one of you weigh in on Jeff's concern here about this patch?
As it happens, I'm just looking at it. I believe there's a small bug in
the patch, I'm just testing it to verify. Stay tuned!
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David E. Wheeler | 2011-07-13 17:28:42 | pg_class.relistemp |
| Previous Message | Tom Lane | 2011-07-13 16:31:34 | Re: Need help understanding pg_locks |