Re: %ENV warnings during builds

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Brar Piening <brar(at)gmx(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: %ENV warnings during builds
Date: 2011-07-04 21:30:44
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 07/03/2011 05:14 PM, Brar Piening wrote:
> schrieb Magnus Hagander:
>> I think you've stumbled on just about all the bits of the MSVC build
>> system we haven't perlized. Maybe we should complete that task, and turn
>> clean.bat, pgbison.bat and pgflex.bat into pure one-line wrappers.
>> (It was
>> done for builddoc just a few weeks ago).
>> Yeah, give nthat you can't get anything useful done without perl
>> anyway, I don't see any argument for keeping them at this point.
> I've already stumbled into this while preparing the VS2010 support and
> came to the same conclusion.
> In my VS2010 support patch I've already created perl replacements for
> those two and removed the batch files completely.
> Certainly those two could also stay around as mere wrappers but in my
> opinion they only mess up the directory without adding any relevant
> benefit.

Hmm, I missed that you had done this. Here are two replacement perl
scripts I knocked up, but haven't yet tested. One of the things about
them is that they remove knowledge of particular .l and .y files. and
instead get the required invocation options from the relevant Makefiles.
I think that's a lot better than the horrid hackery we have in the batch



Attachment Content-Type Size application/x-perl 1.4 KB application/x-perl 978 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Florian Pflug 2011-07-04 21:42:23 Re: Latch implementation that wakes on postmaster death on both win32 and Unix
Previous Message Peter Geoghegan 2011-07-04 21:11:05 Re: Latch implementation that wakes on postmaster death on both win32 and Unix