Re: WIP pgindent replacement

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: David Christensen <david(at)endpoint(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP pgindent replacement
Date: 2011-06-22 12:35:56
Message-ID: 4E01E1AC.5040909@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06/22/2011 02:03 AM, David Christensen wrote:
>> # Avoid bug that converts 'x =- 1' to 'x = -1'
>> $source =~ s!=- !-= !g;
>
> I haven't looked at the shell script this replaces, but is that the correct substitution pattern? (BTW, I'm not seeing the token =- anywhere except in the Makefile, which wouldn't be run against, no? Am I missing something?)
>
>

It's exactly what the current script does. The reason you don't see this
anywhere is that previous pgindent runs have removed it. We don't undo
the transformation. But maybe we should just get rid of it.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-06-22 12:56:02 Re: [v9.2] DROP Reworks Part.0 - 'missing_ok' support of get_object_address
Previous Message Radosław Smogura 2011-06-22 12:31:01 Re: Hugetables question