Re: Estimates not taking null_frac element into account with @@ operator? (8.4 .. git-head)

From: Jesper Krogh <jesper(at)krogh(dot)cc>
To: pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Estimates not taking null_frac element into account with @@ operator? (8.4 .. git-head)
Date: 2011-02-17 22:35:23
Message-ID: 4D5DA2AB.7020202@krogh.cc
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2011-02-17 23:20, Tom Lane wrote:
> Jesper Krogh<jesper(at)krogh(dot)cc> writes:
>> When something evaluates to "null" isn't included in the result,
>> shouldn't the query-planner
>> then take the null_frac into account when computing the estimate?
> The proposed patch seems wrong to me: if we're estimating on the basis
> of most-common-value fractions, the null_frac is already accounted for,
> because it's not part of the MCV selectivity fractions. IOW, aren't you
> double-counting the null fraction?
It might be the wrong place to fix, but here it seems like we're only
counting MCE-freqs based on non-null elements:

http://git.postgresql.org/gitweb?p=postgresql.git;a=blob;f=src/backend/tsearch/ts_typanalyze.c;h=2654d644579fd1959282d83919474f42540ca703;hb=HEAD#l396

And the testdata confirms the behaviour.

--
Jesper

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-02-17 22:50:24 ALTER TYPE COLLATABLE?
Previous Message Tom Lane 2011-02-17 22:20:48 Re: Estimates not taking null_frac element into account with @@ operator? (8.4 .. git-head)