Re: Named restore points

From: Euler Taveira de Oliveira <euler(at)timbira(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Jaime Casanova <jaime(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Named restore points
Date: 2011-02-08 17:07:29
Message-ID: 4D517851.2050608@timbira.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em 08-02-2011 11:05, Simon Riggs escreveu:
> On Fri, 2011-02-04 at 21:15 -0500, Jaime Casanova wrote:
>>>
>>> + else if (recoveryTarget == RECOVERY_TARGET_NAME)
>>> + snprintf(buffer, sizeof(buffer),
>>> + "%s%u\t%s\t%s named restore point %
>> s\n",
>>> + (srcfd< 0) ? "" : "\n",
>>> + parentTLI,
>>> + xlogfname,
>>> + recoveryStopAfter ? "after" :
>> "before",
>>> + recoveryStopNamedRestorePoint);
>>>
>>> It doesn't matter if it is after or before the restore point.
>> After/Before
>>> only make sense when we're dealing with transaction or time.
>> Removed.
>>>
>>
>> you're right
>
> Not sure I understand the comment "only make sense when we're dealing
> with transaction or time." Why?
>
Because named restore point is a noop xlog record; besides, transaction and
time involves xlog records that contain data.

--
Euler Taveira de Oliveira
http://www.timbira.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2011-02-08 17:09:12 Re: Extensions versus pg_upgrade
Previous Message Robert Haas 2011-02-08 16:56:12 Re: postponing some large patches to 9.2