Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] reviewers needed!

From: Andy Colson <andy(at)squeakycode(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-rrreviewers(at)postgresql(dot)org
Subject: Re: [HACKERS] reviewers needed!
Date: 2011-01-16 19:30:58
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-rrreviewers
I reviewed a couple patched, and I added my review to the commitfest page.

If I find a problem, its obvious I should mark the patch as "returned with feedback".

But what if I'm happy with it?  I'm not a hacker so cannot do C code review, should I leave it alone?  Mark it as "ready for committer"?

I marked my two reviews as ready for committer, but I feel like I've overstepped my bounds.


In response to


pgsql-hackers by date

Next:From: Josh BerkusDate: 2011-01-16 20:12:11
Subject: Re: What happened to open_sync_without_odirect?
Previous:From: Tom LaneDate: 2011-01-16 19:28:01
Subject: Re: Bug in pg_describe_object, patch v2

pgsql-rrreviewers by date

Next:From: Euler Taveira de OliveiraDate: 2011-01-16 21:13:30
Subject: Re: [HACKERS] reviewers needed!
Previous:From: Dimitri FontaineDate: 2011-01-15 11:31:21
Subject: Re: reviewers needed!

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group