| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andy Colson <andy(at)squeakycode(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, pgsql-rrreviewers(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] reviewers needed! |
| Date: | 2011-01-16 22:10:49 |
| Message-ID: | AANLkTim4yUSJEiC2QoO38GM7gTXjR-v5qPe+umhs2XLb@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-rrreviewers |
On Sun, Jan 16, 2011 at 2:30 PM, Andy Colson <andy(at)squeakycode(dot)net> wrote:
> I reviewed a couple patched, and I added my review to the commitfest page.
>
> If I find a problem, its obvious I should mark the patch as "returned with
> feedback".
Only if it's got sufficiently serious flaws that getting it committed
during this CommitFest is not practical. If it just needs some
revision, "Waiting on Author" is the right place.
> But what if I'm happy with it? I'm not a hacker so cannot do C code review,
> should I leave it alone? Mark it as "ready for committer"?
Yep, that's fine.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-01-16 22:13:23 | Re: limiting hint bit I/O |
| Previous Message | Noah Misch | 2011-01-16 21:38:38 | Re: ALTER TYPE 0: Introduction; test cases |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Broersma | 2011-01-24 20:17:16 | Seeking Mentors for Funded Reviewers |
| Previous Message | Euler Taveira de Oliveira | 2011-01-16 21:13:30 | Re: [HACKERS] reviewers needed! |