Re: [COMMITTERS] pgsql: Improved parallel make support

On 11/12/2010 11:25 PM, Tom Lane wrote:
> Andrew Dunstan<andrew(at)dunslane(dot)net> writes:
>> On 11/12/2010 03:16 PM, Peter Eisentraut wrote:
>>> Improved parallel make support
>> Looks like this patch has pretty comprehensively broken the MSVC build
>> system. I'll see what I can recover from the wreckage.
> There are also at least three non-Windows buildfarm members failing like
> so:
>
> gmake -C src all
> gmake[1]: Entering directory `/home/pgbuild/pgbuildfarm/HEAD/pgsql.6736/src'
> gmake[1]: *** virtual memory exhausted. Stop.
> gmake[1]: Leaving directory `/home/pgbuild/pgbuildfarm/HEAD/pgsql.6736/src'
> gmake: *** [all-src-recursive] Error 2
>
> I think we may have pushed too far in terms of what actually works
> reliably across different make versions.

Yeah, possibly. And now it looks like this has broken the Solaris
buildfarm members too.

I'm curious to know how much all this buys us. One reason I haven't
enabled parallel make in the buildfarm is that it interleaves the
output, which can be a pain. And build speed isn't really the
buildfarm's foremost concern anyway. I know waiting for a build can be
mildly annoying (ccache can be a big help if you're building
repeatedly). But I don't feel we need to squeeze every last pip out of
the build system.

cheers

andrew