Re: [PATCH] Cleanup of GUC units code

From: Greg Stark <greg(dot)stark(at)enterprisedb(dot)com>
To: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
Cc: Hannu Krosing <hannu(at)krosing(dot)net>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Gregory Stark <stark(at)enterprisedb(dot)com>, Marko Kreen <markokr(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Cleanup of GUC units code
Date: 2008-09-03 15:09:22
Message-ID: 4A3BED8B-FE9E-4C16-A6C2-D9664071BD9E@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I don't think worrying about the message we send to users is
reasonable. We can take responsibilty for the messages we output but
punishing our users to teach them a lesson is being actively user-
hostile

greg

On 3 Sep 2008, at 15:52, "Joshua D. Drake" <jd(at)commandprompt(dot)com> wrote:

> Hannu Krosing wrote:
>> On Tue, 2008-09-02 at 16:50 +0300, Peter Eisentraut wrote:
>>> Gregory Stark wrote:
>>>> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>
>> Are you really afraid that someone would want to use mb to mean
>> millibits ?
>> As SQL is generally case insensitive, it is quite surprising to most
>> people that GUC units are not.
>
> We have had this discussion before, I even submitted a patch to make
> them case insensitive. In retrospect I was wrong to submit that
> patch. SQL may be case insensitive but units are not. MB != Mb !=
> mb , I don't think we should encourage in any way for users to do
> the wrong thing.
>
> Sincerely,
>
> Joshua D. Drake
>
>
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2008-09-03 15:20:51 Re: [PATCH] Cleanup of GUC units code
Previous Message Stephen R. van den Berg 2008-09-03 15:08:01 Re: Function call order dependency