| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Finnerty, Jim" <jfinnert(at)amazon(dot)com> |
| Subject: | Re: Making Vars outer-join aware |
| Date: | 2023-01-30 16:45:27 |
| Message-ID: | 497112.1675097127@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> Sorry for the delayed reply. I don't have any more review comments at
> the moment, except a nitpicking one.
> In optimizer/README at line 729 there is a query as
> SELECT * FROM a
> LEFT JOIN (SELECT * FROM b WHERE b.z = 1) ss ON (a.x = b.y)
> WHERE a.x = 1;
> I think it should be
> SELECT * FROM a
> LEFT JOIN (SELECT * FROM b WHERE b.z = 1) ss ON (a.x = ss.y)
> WHERE a.x = 1;
Oh, good catch, thanks.
> I have no objection to get it committed.
I'll push forward then. Thanks for reviewing!
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-01-30 17:00:31 | Re: pub/sub - specifying optional parameters without values. |
| Previous Message | Tom Lane | 2023-01-30 16:20:48 | Re: MacOS: xsltproc fails with "warning: failed to load external entity" |