Re: PG_GETARG_GISTENTRY?

From: Mark Dilger <hornschnorter(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG_GETARG_GISTENTRY?
Date: 2017-04-24 16:25:25
Message-ID: 494BAB82-1F4C-478A-8EEC-103C79CA5609@gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


> On Apr 5, 2017, at 1:27 PM, Mark Dilger <hornschnorter(at)gmail(dot)com> wrote:
>
>
>> On Apr 5, 2017, at 1:12 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>> Mark Dilger <hornschnorter(at)gmail(dot)com> writes:
>>> I have written a patch to fix these macro definitions across src/ and contrib/.
>>> Find the patch, attached. All regression tests pass on my Mac laptop.
>>
>> Thanks for doing the legwork on that.
>
> You are welcome.
>
>> This seems a bit late for v10,
>> especially since it's only cosmetic
>
> Agreed.
>
>> , but please put it in the first
>> v11 commitfest.
>
> Done.
>
>>
>>> I don't find any inappropriate uses of _P where _PP would be called for. I do,
>>> however, notice that some datatypes' functions are written to use PG_GETARG_*_P
>>> where PG_GETARG_*_PP might be more efficient.
>>
>> Yeah. I think Noah did some work in that direction already, but I don't
>> believe he claimed to have caught everything. Feel free to push further.
>
> Thanks for clarifying.
>

Here is a small patch for the next open commitfest which handles a case
that Noah's commits 9d7726c2ba06b932f791f2d0cc5acf73cc0b4dca and
3a0d473192b2045cbaf997df8437e7762d34f3ba apparently missed.

Noah, if you left this case out intentionally, sorry for the noise. I did not
immediately see any reason not to follow your lead for this function.

Mark Dilger

Attachment Content-Type Size
varbit_packed.patch.1 application/octet-stream 2.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2017-04-24 16:29:51 Re: walsender & parallelism
Previous Message Fujii Masao 2017-04-24 16:13:12 Re: Quorum commit for multiple synchronous replication.