| From: | Mark Dilger <hornschnorter(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PG_GETARG_GISTENTRY? |
| Date: | 2017-04-05 20:27:02 |
| Message-ID: | 1C843B2C-0862-4B63-8795-DA880A18B61B@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Apr 5, 2017, at 1:12 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Mark Dilger <hornschnorter(at)gmail(dot)com> writes:
>> I have written a patch to fix these macro definitions across src/ and contrib/.
>> Find the patch, attached. All regression tests pass on my Mac laptop.
>
> Thanks for doing the legwork on that.
You are welcome.
> This seems a bit late for v10,
> especially since it's only cosmetic
Agreed.
> , but please put it in the first
> v11 commitfest.
Done.
>
>> I don't find any inappropriate uses of _P where _PP would be called for. I do,
>> however, notice that some datatypes' functions are written to use PG_GETARG_*_P
>> where PG_GETARG_*_PP might be more efficient.
>
> Yeah. I think Noah did some work in that direction already, but I don't
> believe he claimed to have caught everything. Feel free to push further.
Thanks for clarifying.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-04-05 20:33:32 | Re: PoC plpgsql - possibility to force custom or generic plan |
| Previous Message | Tom Lane | 2017-04-05 20:12:23 | Re: PG_GETARG_GISTENTRY? |