| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Mark Dilger <hornschnorter(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PG_GETARG_GISTENTRY? |
| Date: | 2017-04-25 01:10:52 |
| Message-ID: | 20170425011052.GA270877@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 24, 2017 at 09:25:25AM -0700, Mark Dilger wrote:
> Here is a small patch for the next open commitfest which handles a case
> that Noah's commits 9d7726c2ba06b932f791f2d0cc5acf73cc0b4dca and
> 3a0d473192b2045cbaf997df8437e7762d34f3ba apparently missed.
The scope for those commits was wrappers of PG_DETOAST_DATUM_PACKED(), which
does not include PG_DETOAST_DATUM_SLICE().
> Noah, if you left this case out intentionally, sorry for the noise. I did not
> immediately see any reason not to follow your lead for this function.
This is not following my lead, but that doesn't make it bad. It's just a
different topic.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2017-04-25 01:11:06 | Re: some review comments on logical rep code |
| Previous Message | Amit Langote | 2017-04-25 01:06:30 | warning in twophase.c |