| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Martin Zaun <Martin(dot)Zaun(at)Sun(dot)COM>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Dave Page <dpage(at)pgadmin(dot)org>, List pgsql-patches <pgsql-patches(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] odd output in restore mode |
| Date: | 2008-12-15 22:08:14 |
| Message-ID: | 4946D54E.4060406@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian wrote:
> Martin Zaun wrote:
>> 4. Issue: missing break in switch, silent override of '-l' argument?
>>
>> This behaviour has been in there before and is not addresses by the
>> patch: The user-selected Win32 "mklink" command mode is never applied
>> due to a missing 'break' in CustomizableInitialize():
>>
>> switch (restoreCommandType)
>> {
>> case RESTORE_COMMAND_WIN32_MKLINK:
>> SET_RESTORE_COMMAND("mklink", WALFilePath, xlogFilePath);
>> case RESTORE_COMMAND_WIN32_COPY:
>> SET_RESTORE_COMMAND("copy", WALFilePath, xlogFilePath);
>> break;
>
> I have added the missing 'break' to CVS HEAD; thanks.
Why no backpatch to 8.3? Seems like a clear bugfix to me.
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2008-12-15 22:10:06 | 8.4 replication questions |
| Previous Message | Bruce Momjian | 2008-12-15 22:08:12 | Re: [PATCHES] odd output in restore mode |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2008-12-15 22:10:46 | Re: [PATCHES] odd output in restore mode |
| Previous Message | Bruce Momjian | 2008-12-15 22:08:12 | Re: [PATCHES] odd output in restore mode |