| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Martin Zaun <Martin(dot)Zaun(at)Sun(dot)COM> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Dave Page <dpage(at)pgadmin(dot)org>, List pgsql-patches <pgsql-patches(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] odd output in restore mode |
| Date: | 2008-12-15 21:15:51 |
| Message-ID: | 200812152115.mBFLFpV20891@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Martin Zaun wrote:
> 4. Issue: missing break in switch, silent override of '-l' argument?
>
> This behaviour has been in there before and is not addresses by the
> patch: The user-selected Win32 "mklink" command mode is never applied
> due to a missing 'break' in CustomizableInitialize():
>
> switch (restoreCommandType)
> {
> case RESTORE_COMMAND_WIN32_MKLINK:
> SET_RESTORE_COMMAND("mklink", WALFilePath, xlogFilePath);
> case RESTORE_COMMAND_WIN32_COPY:
> SET_RESTORE_COMMAND("copy", WALFilePath, xlogFilePath);
> break;
I have added the missing 'break' to CVS HEAD; thanks.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ron Mayer | 2008-12-15 21:40:44 | Re: Sync Rep: First Thoughts on Code |
| Previous Message | Josh Berkus | 2008-12-15 21:06:15 | Re: Sync Rep: First Thoughts on Code |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2008-12-15 22:08:12 | Re: [PATCHES] odd output in restore mode |
| Previous Message | Jaime Casanova | 2008-12-15 19:01:19 | Re: Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1 |