Re: snapshot leak and core dump with serializable transactions

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: snapshot leak and core dump with serializable transactions
Date: 2008-12-03 20:20:48
Message-ID: 4936EA20.4070300@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera wrote:
> Alvaro Herrera escribió:
>
>> Yeah, we need two "at-commit" routines, one of which needs to be called
>> early. I'm prepping a patch.
>
> Here it is ... the large object patch is also included. I've created
> new functions to specify the resource owner to register a snapshot in;
> now that there are two callers, it seems likely that there will be more
> in the future.

I'm surprised you implemented RegisterSnapshotOnOwner by switching
CurrentResourceOwner and calling RegisterSnapshot, rather than
implementing RegisterSnapshot by calling RegisterSnapshotOnOwner(...,
CurrentResourceOwner).

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2008-12-03 20:21:20 Re: Simple postgresql.conf wizard
Previous Message Magnus Hagander 2008-12-03 20:05:54 Re: Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.