Re: Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Russell Smith <mr-russ(at)pws(dot)com(dot)au>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PoolSnoopy <tlatzelsberger(at)gmx(dot)at>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.
Date: 2008-12-03 20:05:54
Message-ID: 4936E6A2.3010806@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Magnus Hagander wrote:
> Bruce Momjian wrote:
>> Bruce Momjian wrote:
>>> Thanks for the review, Magnus. I have adjusted the patch to use the
>>> same mutex every time the counter is accessed, and adjusted the
>>> pqsecure_destroy() call to properly decrement in the right place.
>>>
>>> Also, I renamed the libpq global destroy function to be clearer
>>> (the function is not exported).
>> Here is an updated version of the patch to match CVS HEAD.
>
> I've updated it to match what's CVS HEAD now, and made some minor
> modifications. Renamed destroySSL() to make it consistent with
> initializeSSL(). Added and changed some comments. ssldiff.patch contains
> my changes against Bruce's patch.

I've applied this version for Bruce.

//Magnus

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Denis Monsieur 2008-12-03 23:33:18 BUG #4562: ts_headline() adds space when parsing url
Previous Message Magnus Hagander 2008-12-03 13:56:14 Re: Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2008-12-03 20:20:48 Re: snapshot leak and core dump with serializable transactions
Previous Message Magnus Hagander 2008-12-03 20:04:27 pgsql: Properly unregister OpenSSL callbacks when libpq is done with