Re: Patch for "Panel for Joins in the Graphic Query Builder"

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Luis Ochoa <ziul1979(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Patch for "Panel for Joins in the Graphic Query Builder"
Date: 2008-12-03 10:13:51
Message-ID: 49365BDF.8080409@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Luis Ochoa,

Thanks for reviewing it.
>
> A good way to access the vector, but allowing the code to access
> directly the objects based on the index probably decrease the
> independece of the subyacent structured inside the collection. If I
> decided to change the vector for a hash map in a future this operator
> probably difficult the change by example, because now we have hard
> code access directly to the structure inside the collection.
For the same reason, I have not introduced the operator [] in
gqbCollection class, but in gqbArrayCollection.
I thought - as we are able to access & insert the objects using index.
Then, why not to have direct access to the object (easy for replacement
too).

In case if one of us decide to change the vector for a hash map in a
future, the insertion of an object at a particular index will also
create the same problem, which this operator will do.
What do you say?

Sorry if I misunderstood.

And thanks for the help.

Thanks & Regards,
Ashesh

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2008-12-03 10:42:23 Re: Patch for "Panel for Joins in the Graphic Query Builder"
Previous Message Luis Ochoa 2008-12-02 22:42:18 Re: Patch for "Panel for Joins in the Graphic Query Builder"