Re: [HACKERS] CLUSTER command progress monitor

From: Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: [HACKERS] CLUSTER command progress monitor
Date: 2019-03-25 01:01:46
Message-ID: 490f30fe-2255-4991-65c1-e72bee2a9011@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Robert!

On 2019/03/23 3:31, Robert Haas wrote:
> On Tue, Mar 19, 2019 at 2:47 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> how close you were getting to rewriting the entire heap. This is the
>> one thing I found but did not fix; any chance you could make this
>> change and update the documentation to match?
>
> Hi, is anybody working on this?

I sent this email using my personal email address: yamatattsu(at)gmail-(dot)
I re-send it with the patch and my test result.

Thank you so much for reviewing the patch and sorry for the late reply.
Today, I realized that you sent the email for the patch because I took a
sick leave from work for a while. So, I created new patch based on your comments asap.
I hope it is acceptable to you. :)

Changes
- Add new column *heap_tuples_written* in the view
This column is updated when the phases are "seq scanning heap",
"index scanning heap" or "writing new heap".
- Fix document
- Revised the patch on the current head: 940311e4bb32a5fe99155052e41179c88b5d48af.

Please find attached files. :)

Regards,
Tatsuro Yamada

Attachment Content-Type Size
progress_monitor_for_cluster_command_v12.patch text/x-patch 22.4 KB
test_result.txt text/plain 26.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ryan Lambert 2019-03-25 01:04:24 Re: Fix XML handling with DOCTYPE
Previous Message Amit Langote 2019-03-25 00:31:41 Re: selecting from partitions and constraint exclusion