| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Ewan Young <kdbase(dot)hack(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrey Rachitskiy <pl0h0yp1(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: right() returns the whole string for the most negative n |
| Date: | 2026-09-01 08:23:25 |
| Message-ID: | 48E037F8-F29F-472E-AC12-6EBE1DC4151A@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 27 Aug 2026, at 13:13, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> On 27 Aug 2026, at 07:17, Ewan Young <kdbase(dot)hack(at)gmail(dot)com> wrote:
>> On Thu, Aug 27, 2026 at 10:45 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>> Attached v4 goes back to the explicit PG_INT32_MIN test:
>>
>> if (unlikely(n == PG_INT32_MIN))
>> n = PG_INT32_MAX;
>> else
>> n = -n;
>>
>> which applies cleanly to every supported branch (I checked REL_14 through
>> REL_19 and master). The fix and the regression case are otherwise
>> unchanged.
>
> I will prepare a backpatch all the way of this, and will ping the new thread
> when done. (There is a lof work being done for shipping v19 so have a little
> patience.)
Finally got around to backpatching this to all supported branches. Thanks for
the submission!
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-09-01 08:30:45 | Re: Changing the state of data checksums in a running cluster |
| Previous Message | Michael Paquier | 2026-09-01 08:23:11 | Re: [PATCH] Speed up pg_waldump TAP test and fix some GitHub CI Windows flakiness |