| From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
|---|---|
| To: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: page macros cleanup |
| Date: | 2008-07-04 08:38:04 |
| Message-ID: | 486DE16C.3070705@sun.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Heikki Linnakangas napsal(a):
> Just one quick note:
> Should probably use PageGetSpecialSize here. Much simpler, and doesn't
> assume that the special area is always at the end of page (not that I
> see us changing that anytime soon).
>
Thanks for review,
good catch. I found similar example also in nbtree and hash. I attached updated
patch version which also contains fix for Pavan's observation. Patch modifies
HashMaxItemSize. It should require reindex on all hash indexes. Should we bump
catalog version?
thanks Zdenek
--
Zdenek Kotala Sun Microsystems
Prague, Czech Republic http://sun.com/postgresql
| Attachment | Content-Type | Size |
|---|---|---|
| page_02.patch | text/x-patch | 33.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2008-07-04 08:41:26 | Re: [PATCHES] Multi-column GIN |
| Previous Message | Simon Riggs | 2008-07-04 08:37:10 | Re: Sorting writes during checkpoint |