Re: tzcode update

From: "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Magnus Hagander" <magnus(at)hagander(dot)net>, "Bjorn Munch" <Bjorn(dot)Munch(at)sun(dot)com>, <pgsql-patches(at)postgresql(dot)org>
Subject: Re: tzcode update
Date: 2008-02-20 10:29:26
Message-ID: 47BC0106.5040300@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Mon, Feb 18, 2008 at 04:32:58PM +0100, Bjorn Munch wrote:
>>> Ouch! This fails on our Solaris builds, because we build with the
>>> Solaris timezone files. And these apparently don't work beyond 2038
>>> and don't know that Finland plans to have DST also in the summer of
>>> 2050...
>>>
>>> I haven't studied this in depth but I'm afraid the answer is "fix your
>>> own timezone files"?
>
>> Or use the ones shipping with pg ;-)
>
> Yeah. I included the far-future cases in the committed patch
> specifically to make it obvious if you were using tz files that lacked
> post-2038 support.

Agreed, we want to give people a notice.

What we could do is to add comments to the expected output file, that
would show up in regression.diffs, that explain what the failure means.

> I can't imagine that fixing this isn't pretty darn high on the Solaris
> to-do list, anyway.

Yep, and PostgreSQL 8.4 won't be released for quite some time.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-02-20 18:14:52 Re: BUG #3969: pg_ctl cannot detect server startup
Previous Message ITAGAKI Takahiro 2008-02-20 03:05:11 Re: BUG #3969: pg_ctl cannot detect server startup