From: | Dave Page <dpage(at)postgresql(dot)org> |
---|---|
To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
Cc: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: A new feature patch and a bug fix |
Date: | 2007-12-17 16:53:28 |
Message-ID: | 4766A988.60409@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Guillaume Lelarge wrote:
> Dave Page wrote:
>> Index: pgadmin/dlg/dlgProperty.cpp
>> ===================================================================
>> --- pgadmin/dlg/dlgProperty.cpp (révision 6910)
>> +++ pgadmin/dlg/dlgProperty.cpp (copie de travail)
>> @@ -432,7 +432,14 @@
>>
>> void dlgProperty::AddUsers(ctlComboBoxFix *cb1, ctlComboBoxFix *cb2)
>> {
>> - FillCombobox(wxT("SELECT usename FROM pg_user ORDER BY usename"),
>> cb1, cb2);
>> + if (connection->BackendMinimumVersion(8, 1))
>> + {
>> + FillCombobox(wxT("SELECT rolname FROM pg_roles ORDER BY 1"),
>> cb1, cb2);
>> + }
>> + else
>> + {
>> + FillCombobox(wxT("SELECT usename FROM pg_user ORDER BY 1"),
>> cb1, cb2);
>> + }
>> }
>>
>
> I'm OK with this.
Please go ahead and commit at your leisure :-)
/D
From | Date | Subject | |
---|---|---|---|
Next Message | svn | 2007-12-17 17:01:51 | SVN Commit by guillaume: r6911 - trunk/pgadmin3/pgadmin/dlg |
Previous Message | Guillaume Lelarge | 2007-12-17 16:48:47 | Re: A new feature patch and a bug fix |