Re: A new feature patch and a bug fix

Dave Page wrote:
> Guillaume Lelarge wrote:
>> Dave Page wrote:
>>> Guillaume Lelarge wrote:
>>>> I did it for a group, works great (8.1 and 8.2). Now, I don't really
>>>> know if this is really a feature or something overlooked. Either pgAdmin
>>>> is wrong either psql is.
>>> No, in 8.1+ it works for roles whether they are what we would call login
>>> roles or group roles. In 8.0 and below we had separate users and groups,
>>> but I'm not sure you could assign ownership to a group back then.
>>>
>> You're right. I checked this on a 7.4 (I don't have a 8.0 release
>> available) and, with this release, a group can't be the owner of a table.
>>
>> Do you think I should raise the issue (group owner on 8.1+) on
>> pgsql-hackers ?
>
> No - I think it just works because pg_group is a view over pg_role (or
> whatever it's called ) on 8.1. I would try something like:
>
> Index: pgadmin/dlg/dlgProperty.cpp
> ===================================================================
> --- pgadmin/dlg/dlgProperty.cpp (révision 6910)
> +++ pgadmin/dlg/dlgProperty.cpp (copie de travail)
> @@ -432,7 +432,14 @@
>
> void dlgProperty::AddUsers(ctlComboBoxFix *cb1, ctlComboBoxFix *cb2)
> {
> - FillCombobox(wxT("SELECT usename FROM pg_user ORDER BY usename"),
> cb1, cb2);
> + if (connection->BackendMinimumVersion(8, 1))
> + {
> + FillCombobox(wxT("SELECT rolname FROM pg_roles ORDER BY 1"),
> cb1, cb2);
> + }
> + else
> + {
> + FillCombobox(wxT("SELECT usename FROM pg_user ORDER BY 1"),
> cb1, cb2);
> + }
> }
>

I'm OK with this.

Thanks.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com