wrong behavior using to_char() again

Hi,

Looking again at bug report [1], I agree that's a glibc bug. Numbers in
pt_BR has its format 1.234.567,89; sometimes the format 1234567,89 is
acceptable too, ie, the thousand separator is optional. I guess that
some locales use the 'optional' thousand separator too (yep, they are
all broken too).

euler(at)harman:/a/pgsql$ ./a.out pt_BR
decimal_point: ,
thousands_sep:
euler(at)harman:/a/pgsql$ ./a.out fr_FR
decimal_point: ,
thousands_sep:
euler(at)harman:/a/pgsql$ ./a.out es_ES
decimal_point: ,
thousands_sep:
euler(at)harman:/a/pgsql$ ./a.out de_DE
decimal_point: ,
thousands_sep: .
euler(at)harman:/a/pgsql$ ./a.out C
decimal_point: .
thousands_sep:

The actual behavior is set: (i) "," if the thousand separator is "" (ii)
"." if the decimal point is "". It is not what glibc says (even in the C
locale). I expect that PostgreSQL agrees with glibc (even it's the wrong
behavior). Given this assumption, i propose the attached patch (it needs
to adjust the regression tests).

Comments?

[1] http://archives.postgresql.org/pgsql-bugs/2006-09/msg00074.php

--
Euler Taveira de Oliveira
http://www.timbira.com/