Re: Threading fix for AIX

From: "Zeugswetter Andreas DAZ SD" <ZeugswetterA(at)spardat(dot)at>
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Peter Eisentraut" <peter_e(at)gmx(dot)net>, "Simon Riggs" <simon(at)2ndquadrant(dot)com>, "Andrew Sullivan" <ajs(at)crankycanuck(dot)ca>, "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Threading fix for AIX
Date: 2004-12-14 15:28:30
Message-ID: 46C15C39FEB2C44BA555E356FBCD6FA40184D270@m0114.s-mxs.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


>> 1. the snprintf long long int check that uses int64 as variable name which is
>> a typedef in sys/inttypes.h
>
> I changed it to ac_int64. Does that help?

One more is needed in c-library.m4.

>> 2. whether strerror_r returns int check fails with a redefine of named function
>> from string.h
>
> I see. Our test is:
> int strerror_r(int, char *, size_t);
> but AIX is:
> int strerror_r(int, char *, int);
> OK, I added an #ifndef _AIX to use 'int' for the 3rd arg for AIX.

The wrong define is only on older AIX versions :-(
And the patch produces wrong code asis (missing # and #endif).
Since AIX always has the int returning function, how about no test on AIX:
#ifndef_AIX
int strerror_r(int, char *, size_t);
#endif

> Please test this patch and report back. Thanks.

attached is a reworked patch that works on aix 4.3.2 and 5.2, please check the configure part,
cause I don't have autoconf.

Andreas

Attachment Content-Type Size
pg_aix_threads.patch application/octet-stream 6.7 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-12-14 19:57:20 Re: Threading fix for AIX
Previous Message hyip 2004-12-14 12:48:20 Re: Optional REFERENCES Feature in CREATE TRIGGER Command