Re: Threading fix for AIX

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Zeugswetter Andreas DAZ SD <ZeugswetterA(at)spardat(dot)at>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andrew Sullivan <ajs(at)crankycanuck(dot)ca>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Threading fix for AIX
Date: 2004-12-14 19:57:20
Message-ID: 200412141957.iBEJvKL26605@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Zeugswetter Andreas DAZ SD wrote:
>
> >> 1. the snprintf long long int check that uses int64 as variable name which is
> >> a typedef in sys/inttypes.h
> >
> > I changed it to ac_int64. Does that help?
>
> One more is needed in c-library.m4.

OK, done.

> >> 2. whether strerror_r returns int check fails with a redefine of named function
> >> from string.h
> >
> > I see. Our test is:
> > int strerror_r(int, char *, size_t);
> > but AIX is:
> > int strerror_r(int, char *, int);
> > OK, I added an #ifndef _AIX to use 'int' for the 3rd arg for AIX.
>
> The wrong define is only on older AIX versions :-(
> And the patch produces wrong code asis (missing # and #endif).
> Since AIX always has the int returning function, how about no test on AIX:
> #ifndef_AIX
> int strerror_r(int, char *, size_t);
> #endif

I would rather keep testing. Hardcoding platforms stuff usually fails
in some way.

>
> > Please test this patch and report back. Thanks.
>
> attached is a reworked patch that works on aix 4.3.2 and 5.2, please check the configure part,
> cause I don't have autoconf.

I modified my patch to fix the problems you reported. Please report
back.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 0 bytes

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-12-14 20:01:19 Re: Threading fix for AIX
Previous Message Zeugswetter Andreas DAZ SD 2004-12-14 15:28:30 Re: Threading fix for AIX