Re: COPY-able sql log outputs

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: FAST PostgreSQL <fastpgs(at)fast(dot)fujitsu(dot)com(dot)au>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: COPY-able sql log outputs
Date: 2007-04-03 16:26:32
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

FAST PostgreSQL wrote:
>> Am Dienstag, 3. April 2007 20:33 schrieb FAST PostgreSQL:
>>> Attached is the completed patch for the COPY-able sql log outputs.
>> Could you please remove random whitespace changes from this patch?
> Done and attached.

Brief review of the CSV aspect only:

a. username and databasename should probably be quoted and escaped in
case they contain dangerous characters (even though that's unlikely)
b. calling pg_get_client_encoding() inside the loop in
escape_string_literal seems suboptimal. At the very least it should be
moved outside the loop so it's only called once per string.



In response to


Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-04-03 16:59:44 Re: Fix CheckpointStartLock starvation
Previous Message NikhilS 2007-04-03 15:36:10 Re: Auto Partitioning Patch - WIP version 1