| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: egrep is obsolescent |
| Date: | 2026-05-13 15:32:28 |
| Message-ID: | 45b40fd1-1865-44e4-9030-123c52aefda3@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 13.05.26 17:24, Tom Lane wrote:
> While running pgperltidy just now on my recently-updated
> Linux workstation, I got
>
> $ src/tools/pgindent/pgperltidy .
> egrep: warning: egrep is obsolescent; using grep -E
>
> OK, that's a bit in-your-face, but it's not inaccurate.
> AFAICT, "egrep" has never been in POSIX, while "grep -E"
> has been there at least since POSIX 2008.
>
> So I propose the attached patch, which is just s/egrep/grep -E/g.
Looks good to me.
> I did not touch the two usages in port/aix/mkldexport.sh, though.
> I'm not sure what the standardization situation is in AIX, and
> this warning doesn't seem like something they'd do anyway.
It appears that those invocations don't actually need the "e" part of
egrep, so they could just be grep?
> There is also a reference in configure, which is not a problem
> because it tries "grep -E" first.
Yeah, Autoconf addressed this some decades ago, so it should be fine.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Paul A Jungwirth | 2026-05-13 15:39:43 | FOR PORTION OF should reject GENERATED columns |
| Previous Message | Sami Imseih | 2026-05-13 15:28:42 | Re: Vacuumlo improvements |