From: | Dave Page <dpage(at)postgresql(dot)org> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Remove unsafe calling of WSAStartup and WSA Cleanup from DllMain. |
Date: | 2007-03-09 08:16:12 |
Message-ID: | 45F117CC.6090107@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander wrote:
>> For example, do you recall us being confused
>> when we found we needed to call it in slon.exe?
>
> Eh, no, actually not. Sorry.
Well, it was only a couple of years ago!! Seriously though, from what I
recall that was the origin of this code - you left it out because libpq
called WSAStartup on your system, and I added it because on mine it
didn't. Or something like that. I remember us getting confused about it
on IM anyway.
#ifdef WIN32
/*
* Startup the network subsystem, in case our libpq doesn't
*/
err = WSAStartup(MAKEWORD(1, 1), &wsaData);
if (err != 0) {
slon_log(SLON_FATAL, "main: Cannot start the network
subsystem - %d\n", err);
slon_exit(-1);
}
#endif
/D
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2007-03-09 11:33:08 | Re: [COMMITTERS] pgsql: Remove unsafe calling of WSAStartup and WSA Cleanup from DllMain. |
Previous Message | Magnus Hagander | 2007-03-08 20:52:19 | Re: pgsql: Remove unsafe calling of WSAStartup and WSA Cleanup from DllMain. |
From | Date | Subject | |
---|---|---|---|
Next Message | Grzegorz Jaskiewicz | 2007-03-09 08:39:00 | Re: RFC: changing autovacuum_naptime semantics |
Previous Message | August Zajonc | 2007-03-09 07:44:46 | Re: Acclerating INSERT/UPDATE using UPS |