| From: | Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc> |
|---|---|
| To: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com> |
| Cc: | Bruce Momjian <momjian(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Reduce WAL activity for page splits: > Currently, an index split |
| Date: | 2007-02-08 10:03:04 |
| Message-ID: | 45CAF558.5030408@kaltenbrunner.cc |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Heikki Linnakangas wrote:
> Stefan Kaltenbrunner wrote:
>> Bruce Momjian wrote:
>>> Log Message:
>>> -----------
>>> Reduce WAL activity for page splits:
>>>
>>>> Currently, an index split writes all the data on the split page to
>>>> WAL. That's a lot of WAL traffic. The tuples that are copied to the
>>>> right page need to be WAL logged, but the tuples that stay on the
>>>> original page don't.
>>
>>
>> this patch killed both of my OpenBSD buildfarm members
>
> lopaque was referenced after pfreeing the temp page it pointed to. Also
> later in the function the LSN of the left page was set, but again using
> a pointer to the pfreed temp copy instead of the real shared memory buffer.
>
> Here's a fix.
confirmed - with that patch -HEAD passes a full regression test run at
least on emu.
Stefan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2007-02-08 11:10:28 | pgsql: Normalize fgets() calls to use sizeof() for calculating the |
| Previous Message | Heikki Linnakangas | 2007-02-08 09:45:35 | Re: Re: [COMMITTERS] pgsql: Reduce WAL activity for page splits: > Currently, an index split |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Markus Schiltknecht | 2007-02-08 10:12:24 | compilation of pg_config fails |
| Previous Message | Heikki Linnakangas | 2007-02-08 09:45:35 | Re: Re: [COMMITTERS] pgsql: Reduce WAL activity for page splits: > Currently, an index split |