From: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com> |
---|---|
To: | Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc> |
Cc: | Bruce Momjian <momjian(at)postgresql(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Re: [COMMITTERS] pgsql: Reduce WAL activity for page splits: > Currently, an index split |
Date: | 2007-02-08 09:45:35 |
Message-ID: | 45CAF13F.6020008@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Stefan Kaltenbrunner wrote:
> Bruce Momjian wrote:
>> Log Message:
>> -----------
>> Reduce WAL activity for page splits:
>>
>>> Currently, an index split writes all the data on the split page to
>>> WAL. That's a lot of WAL traffic. The tuples that are copied to the
>>> right page need to be WAL logged, but the tuples that stay on the
>>> original page don't.
>
>
> this patch killed both of my OpenBSD buildfarm members
lopaque was referenced after pfreeing the temp page it pointed to. Also
later in the function the LSN of the left page was set, but again using
a pointer to the pfreed temp copy instead of the real shared memory buffer.
Here's a fix.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
lopaque-ref-after-pfree-fix.patch | text/x-patch | 1.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Stefan Kaltenbrunner | 2007-02-08 10:03:04 | Re: Re: [COMMITTERS] pgsql: Reduce WAL activity for page splits: > Currently, an index split |
Previous Message | Heikki Linnakangas | 2007-02-08 09:20:59 | Re: Re: [COMMITTERS] pgsql: Reduce WAL activity for page splits: > Currently, an index split |
From | Date | Subject | |
---|---|---|---|
Next Message | Stefan Kaltenbrunner | 2007-02-08 10:03:04 | Re: Re: [COMMITTERS] pgsql: Reduce WAL activity for page splits: > Currently, an index split |
Previous Message | Zeugswetter Andreas ADI SD | 2007-02-08 09:35:47 | Re: Proposal: Commit timestamp |