Re: [pgsql-patches] Patch to avoid gprof profilingoverwrites

From: Mark Kirkwood <markir(at)paradise(dot)net(dot)nz>
To: korryd(at)enterprisedb(dot)com
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [pgsql-patches] Patch to avoid gprof profilingoverwrites
Date: 2007-02-01 05:52:57
Message-ID: 45C18039.3050107@paradise.net.nz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

korryd(at)enterprisedb(dot)com wrote:
>> The name for the define variable could perhaps be better - feels silly
>> adding -DLINUX_PROFILE on Freebsd! (maybe just PROFILE or GPROF_PROFILE?).
>
> That wasn't my choice, there is other code elsewhere that depends on
> that symbol, I just added a little bit more.
>

Right - but LINUX_PROFILE was added to correct Linux specific oddities
with the time counter accumulation, whereas your patch is not Linux
specific at all. So I think a more representative symbol is required.

Cheers

Mark

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Mark Kirkwood 2007-02-01 05:59:24 Re: [pgsql-patches] Patch to avoid gprof profilingoverwrites
Previous Message Bruce Momjian 2007-02-01 05:14:03 Re: [HACKERS] Typo in pg_dump documentation and new suggestion for Release Notes